Updates for some of the ARC feedback #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the ARC feedback regarding secondary cores. Fixes: riscv-non-isa#183 Closes: riscv-non-isa#183 Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Remove text around supporting deprecated SBI legacy console. Fixes: riscv-non-isa#203 Closes: riscv-non-isa#203 Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Fixes: riscv-non-isa#201 Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
As per ARC feedback, change the Table headings from Requirements to Rules. Fixes: riscv-non-isa#199 Closes: riscv-non-isa#199 Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Clarify AML_020 requirement that DWordIo etc are ASL macros instead of resource types. Add missing other IO macros as well. Fixes: riscv-non-isa#197 Closes: riscv-non-isa#197 Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
|
@andreiw @adurbin-rivos @avpatel - please review. |
|
Overall all changes looks good to me. |
|
thanks, looks good - merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address below ARC feedbacks.