Update according to issues #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix contradictory statement in dmode Align mdbgen naming
|
@gokhankaplayan could you help review the PR? |
|
It is not directly topic of this PR, but it would be better to name sec_check as sec_check[i] for consistency. Do you think we can target this issue in this PR, @AoteJin ? |
Thank you very much for the PR @AoteJin. We put our comments with my colleague @vicky-goode-img. The changes about #23 and |
sure, we can do it. |
gokhankaplayan
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error report fields anysecfault/allsecfault in dmstatus #16
Align mdbgen naming #23
Fix contradictory statement in dmode #24