Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate immediates into separate wavedrom files. #1631

Merged

Conversation

wmat
Copy link
Collaborator

@wmat wmat commented Sep 6, 2024

This separates the immediates into separate wavedrom files which allows us to add the caption to the last immediate on the page (j-immediate) which puts it after the grouping of wavedroms correctly.

This separates the immediates into separate wavedrom files which allows us to
add the caption to the last immediate on the page (j-immediate) which puts it
after the grouping of wavedroms correctly.
@wmat wmat linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. There was an unnecessary page break before the figure, so I deleted it as part of this PR.

@aswaterman aswaterman enabled auto-merge (squash) September 6, 2024 23:19
@aswaterman aswaterman merged commit 4a4efdc into main Sep 6, 2024
2 checks passed
@aswaterman aswaterman deleted the 1624-figure-caption-for-figure-1-is-in-the-wrong-place branch September 6, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure caption for Figure 1 is in the wrong place.
2 participants