Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Smsdedbg per issue 21 and 26 #35

Merged
merged 29 commits into from
Apr 8, 2024
Merged

Updates to Smsdedbg per issue 21 and 26 #35

merged 29 commits into from
Apr 8, 2024

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented Feb 23, 2024

add changes to Smsdedbg normative behavior per discussion in issue 26.
Also proposed changes to be documented in the Secure Ext debug spec to enable the behavior required for Smsdedbg.

@rsahita
Updates to Smsdedbg per issue 26
7dbdb40 
Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita rsahita mentioned this pull request Feb 23, 2024
Closed
@rsahita
Copy link
Collaborator Author

rsahita commented Feb 23, 2024

cc @AoteJin @ved-rivos

@rsahita rsahita self-assigned this Feb 23, 2024
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Feb 25, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@ved-rivos ved-rivos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

rsahita
rsahita commented Feb 26, 2024
View reviewed changes
Copy link
Collaborator Author

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for feedback

rsahita and others added 2 commits March 19, 2024 06:46
@rsahita
Updates to address issues 21, 26 (chapter 8)
b030e7c 
Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita @ved-rivos
Apply suggestions from spec review
abbcdb1 
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita rsahita removed the request for review from kasanovic March 19, 2024 13:48
@rsahita
Merge branch 'main' into topic/extdbg-updates
b615488 
Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita rsahita mentioned this pull request Mar 19, 2024
Closed
@rsahita
Copy link
Collaborator Author

rsahita commented Mar 20, 2024

cc @bcstrongx

bcstrongx
bcstrongx reviewed Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
bcstrongx
bcstrongx reviewed Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
bcstrongx
bcstrongx reviewed Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
bcstrongx
bcstrongx reviewed Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
bcstrongx
bcstrongx reviewed Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Mar 20, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
faa0b43 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita rsahita requested a review from ved-rivos March 20, 2024 19:55
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
8d2f5cb 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter3.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
ff8e544 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
e64c386 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 5, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
2ab4b40 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
AoteJin
AoteJin reviewed Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
628deb8 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita rsahita requested a review from AoteJin April 8, 2024 02:26
AoteJin
AoteJin approved these changes Apr 8, 2024
View reviewed changes
Copy link

@AoteJin AoteJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording might be improved in the long run, but the general idea looks good to me. Thanks!

ved-rivos
ved-rivos reviewed Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Show resolved Hide resolved
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
b02b1c7 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 8, 2024
View reviewed changes
chapter8.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
c80cca4 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita rsahita merged commit e0688d1 into main Apr 8, 2024
1 check passed
@rsahita rsahita deleted the topic/extdbg-updates branch April 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcstrongx bcstrongx bcstrongx left review comments

@ved-rivos ved-rivos ved-rivos approved these changes

@AoteJin AoteJin AoteJin approved these changes

@gokhankaplayan gokhankaplayan Awaiting requested review from gokhankaplayan

Assignees

@rsahita rsahita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsahita @AoteJin @ved-rivos @bcstrongx @gokhankaplayan