Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smmtt updates per TG call on 4/30 #48

Merged
merged 11 commits into from
May 29, 2024
Merged

smmtt updates per TG call on 4/30 #48

merged 11 commits into from
May 29, 2024

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented May 13, 2024

Addressed opens discussed in the 4/30 TG call : https://lists.riscv.org/g/tech-smmtt/message/67

-Moved theory of operation of memory isolation (non-normative) to intro chapter 1
-Updated figure showing logical enforcement of MTT (hart and IO side accesses)
-Updated intro to extensions chapter 2
-Added clarification on SDID usage as local id, PMP usage
-Added description of MTT synchronization (was TBD)
-Fixed glossary errors

Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita rsahita self-assigned this May 13, 2024
Copy link
Collaborator

@kasanovic kasanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good step forward. One thing is the name of the FENCE.MTT instruction - it might be probably more accurately named an MFENCE.SD instruction as it can be used without MTT tables in memory, and is only for M-mode.

Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita
Copy link
Collaborator Author

rsahita commented May 14, 2024

A good step forward. One thing is the name of the FENCE.MTT instruction - it might be probably more accurately named an MFENCE.SD instruction as it can be used without MTT tables in memory, and is only for M-mode.

Please see updated PR @kasanovic

chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
chapter2.adoc Outdated Show resolved Hide resolved
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
exceptions. The exception conditions for MTT are checked when the access
to memory is performed.

=== Caching of MTT and Supervisor Domain Fence Instruction
Copy link
Collaborator

@ved-rivos ved-rivos May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is mostly redundant and covered by the MFENCE.SPA and MINVAL.SPA. Whether MTT is cached is microarchitectural. The last paragraph and the note preceeding that could be moved inline with these instructions description and rest of this section removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought of keeping this section since it is in the normative Smmtt part of the spec. if anything is incorrect here we should fix it, but o/w it seems useful.

chapter4.adoc Outdated Show resolved Hide resolved
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita rsahita requested a review from ved-rivos May 28, 2024 17:17
@rsahita rsahita merged commit df9b9cc into main May 29, 2024
1 check passed
@rsahita rsahita deleted the topic/smmtt-updates branch May 29, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants