ignore arguments that start with +

[colinschmidt]

This causes htif to skip unknown arguments that start with +.

Other arguments that start with - will still issue stderr messages but not stop option parsing.

This is an improvement on current handling where htif will silently treat unknown arguments that start with + as target arguments.

Open to suggestions but this is a strawman for handling chipsalliance/rocket-chip#1194

[mwachs5]

@seldridge does this make sense with chipsalliance/rocket-chip#1192?

[seldridge]

Yes, they should be mutually exclusive as HTIF argument parsing happens after emulator.cc argument parsing. The PlusArg PR (chipsalliance/rocket-chip#1192) effectively only generates your plusarg struct and the help text based on Chisel code. So, if this PR works with rocket-chip master then the chipsalliance/rocket-chip#1192 shouldn't be an incompatible approach.

Famous last words, however, as I keep delaying testing this with VCS (it's a pain for a variety of reasons...) and there are no regressions that bang on these specific plus args...

[aswaterman]

Doesn't this say, "if the argument contains a + anywhere besides the first character, stop parsing arguments"? Should it be if (arg.find("+") == std::string::npos)?

[seldridge]

I think this is okay. find should return something non-zero (or npos which is a big number) if it finds something that doesn't start with a +. Looking for npos would be too restrictive as there could be a binary with a + in the middle of it. It's a stretch, but possible.