fix(source): make s3 source compatible with minio #16521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabVersion
approved these changes
Apr 28, 2024
I don’t think it’s necessary at first, because we already have s3, and adding another one will only make the CI heavier😄. |
hzxa21
approved these changes
May 7, 2024
st1page
reviewed
May 20, 2024
| @@ -58,8 +58,6 @@ impl<Src: OpendalSource> OpendalEnumerator<Src> { | |||
| ); | |||
| } | |||
|
|
|||
| builder.enable_virtual_host_style(); | |||
There was a problem hiding this comment.
cherry-pick it into release-1.9 because some users using the S3 bucket name with dot . and will meet error here https://github.com/apache/opendal/blame/ac694375da955ea6d3461aee0bfafd5a5d774541/core/src/services/s3/backend.rs#L600-L614
st1page
pushed a commit
that referenced
this pull request
May 20, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR
enable_virtual_host_styleso that bothvirtual_path_style: s3.endpoint_url = 'http://127.0.0.1:9301'andforce_path_style: s3.endpoint_url = 'http://<bucket>.127.0.0.1:9301'can work well with minio. (Before this pr neither method works for minio. )backon, refer to fix: fixwith_factorassert Xuanwo/backon#68Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.