fix(pgwire): allow configuring tcp keepalive idle time #18136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
chenzl25
approved these changes
Aug 20, 2024
stdrc
reviewed
Aug 20, 2024
src/utils/pgwire/src/net.rs
Outdated
Comment on lines
85
to
89
| { | ||
| let r = socket2::SockRef::from(&stream); | ||
| let ka = socket2::TcpKeepalive::new().with_time(Duration::from_secs(300)); | ||
| r.set_tcp_keepalive(&ka)?; | ||
| } |
There was a problem hiding this comment.
Interesting. Is this a hack or a common usage of socket2?
There was a problem hiding this comment.
I think it's the common usage and the only way for setting these extra parameters until tokio-rs/tokio#3082 is addressed.
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
What about cp to 2.0? |
stdrc
approved these changes
Aug 21, 2024
arkbriar
reviewed
Aug 21, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
changed the title
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
It's common for an SQL statement not returning any data from the pgwire server for a long time (typically when executing DDL). If the connection is proxied through a load balancer, the LB may consider the connection idle and drop it unexpectedly.
To resolve this issue, we may set the tcp keepalive idle time to a lower value. Here we take a reference to the value in AWS ELB, which is 350 seconds. Note that this can be done in any place dealing with the connection, but doing it on the pgwire server eliminates the need for any additional configuration.
The value is configurable through CLI args and defaults to 300 seconds.
FYI, the default keepalive idle time is decided by the operating system, typically 2 hours.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.