fix(frontend): refine error messages for invalid operations #6548
Conversation
Co-authored-by: clundro <clusternlh@gmail.com>
| table: TableWithJoins, | ||
| table_name: ObjectName, |
There was a problem hiding this comment.
Update joins is mysql's syntax
| @@ -136,53 +136,6 @@ fn parse_update() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_update_with_table_alias() { | |||
| let sql = "UPDATE users AS u SET u.username = 'new_user' WHERE u.username = 'old_user'"; | |||
There was a problem hiding this comment.
pg support this (and also DELETE .. AS .., which is not supported by parser now), but maybe let's do it later.
Codecov Report
@@ Coverage Diff @@
## main #6548 +/- ##
==========================================
- Coverage 74.07% 73.99% -0.08%
==========================================
Files 989 993 +4
Lines 161850 162086 +236
==========================================
+ Hits 119888 119941 +53
- Misses 41962 42145 +183
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
changed the title
| table: TableWithJoins, | ||
| table_name: ObjectName, |
| @@ -0,0 +1,394 @@ | |||
| # 1. drop non-existent relation | |||
|
|
|||
| statement error table not found | |||
There was a problem hiding this comment.
Can we maintain these error messages without pain? 🥵
There was a problem hiding this comment.
What is the pain you mean?
There was a problem hiding this comment.
Do we have to manually update all these error messages if we change them in the future?
There was a problem hiding this comment.
Yes, but since it’s regexp match instead of full match, and it won’t be frequently changed, I think it won’t be a huge pain 🫣
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #3258 (replace)
Checklist
./risedev check(or alias,./risedev c)