EliteAPI fix, NetworkCompatiblity fix and more #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xiaoxiao921
commented
Aug 21, 2020
xiaoxiao921
commented
- Fix an oob array exception with EliteAPI that was adding incorrectly custom elites of tier 2 and above.
- Better display of missing mods for end users when a mod mismatch happens
- Better log message if the monomod patch of r2api is missing
- R2API now adds itself to the networked mod list for syncing purposes when NetworkingAPI is active (the message classes from that API could be different across r2api versions and cause problems for example)
- Fix a rare bug ( computer specific ? ) where the NetworkCompatiblityHandler wasnt correctly retrieving the arguments of the NetworkCompatibility attribute
- Better detection of duplicate assemblies that could be sitting in the plugins folder of an end user
…ve multiple BepinPlugin types in it - Add Debug Log when the plugin scanner fails to scan an assembly
… mod mismatch happen - Add a more detailed error message when the monomod patch of r2api is not loaded
…(R2API.IsLoaded isnt available yet)
…an affect networking and ready to use messages could be different from a r2api version to another
|
Perhaps it would be a good to have an error logged if a mod is requesting both networkAPI to be loaded, and requesting to be clientside. Those two things combined could cause weird mismatch cases. (and don't make any sense anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.