Phedg1 #234
Merged
Phedg1 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed drop list operation lists so they are cleared each time they are used,
as a stop gap measure so my other mods would be able to continue functioning
normally. I know Rein's methods will make this redundant shortly.
Drop lists should never be empty now and will always contain PickupIndex.none
instead. This was for increased consistency, as previously these lists could
sometimes contain none and sometimes be empty, causing bugs.
Added function to determine if a drop list only contained PickupIndex.none, this
has been substituted in wherever a check was done previously to see if a
drop list was empty.
All world unique items are now stored in a list in Catalog and are no longer
added to the subset drop lists in DropList by default.
When using the command artifact, world unique items will now be listed by
themselves unless they are added to the subset drop list of their tier.
Boss drops now check their availability against the world unique drop list if
their drop is a world unique item.
Added ability to add items of any tier to any drop list. Added hooks and functionality so the artifact of command interfact can display a custom list. Added hooks so interactables would not filter drop lists to limit them to specific tiers. Altered tiers in InteractableCalculator so items in a tier of drop list could be differentiated from items of a tier in any drop list. Added functions to Reflection for getting nested field and method infos. Added function to Reflection log all opcodes for a cursor to help with debugging. Added function to Reflection for getting a generic method info when multiple functions with the same name exist. Added Unity physics module dependency for a hook that required the Collision type. Fixed bug in MonsterItemsAPI that occured when the ItemDropAPI drop lists differed from the MonsterItemsAPI drop lists.
|
It's worth noting that in order to add this extra functionality the surface area of this module is MUCH greater. |
harbingerofme
requested changes
Dec 2, 2020
Added proper binding flags to my contributions in Reflection. Steamlined my contributions in Reflection. Enumerated the drop types in InteractableCalculator. Removed some checks against the Run drop lists and increased relaince on InteractableCalculator TiersPresent. Expanded IsValidList so it returns false when given an empty list.
harbingerofme
approved these changes
Dec 2, 2020
tristanmcpherson
requested changes
Dec 4, 2020
| return null; | ||
| } | ||
|
|
||
| public static void LogCursorOpcodes(ILCursor cursor) { |
There was a problem hiding this comment.
What's the difference between this and just logging the cursor to string?
There was a problem hiding this comment.
I didn't know you could just log the cursor to a string. If you can do that then I agree that this function is redundant.
| cursor.Index = indexOld; | ||
| } | ||
|
|
||
| public static MethodInfo GetGenericMethod(Type type, string name, Type[] parameters) { |
There was a problem hiding this comment.
This is no longer needed, correct?
| @@ -923,5 +925,60 @@ public static class Reflection { | |||
| } | |||
|
|
|||
| #endregion | |||
|
|
|||
| public static System.Reflection.FieldInfo GetNestedField(Type type, string fieldName) { | |||
There was a problem hiding this comment.
We could replace these two with a generic GetNestedMember and take in a generic type parameter that is constrained to a MemberInfo like here:
R2API/R2API/Utils/Reflection.cs
Line 196 in 1d9c3bd
There was a problem hiding this comment.
That would be good. Would you like to persue that change or should I? I'm not familiar with creating generic type functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to have items of any tier in any drop list
Added ability to add items of any tier to any drop list.
Added hooks and functionality so the artifact of command interfact can display a custom list.
Added hooks so interactables would not filter drop lists to limit them to specific tiers.
Altered tiers in InteractableCalculator so items in a tier of drop list could be differentiated from items of a tier in any drop list.
Added functions to Reflection for getting nested field and method infos.
Added function to Reflection log all opcodes for a cursor to help with debugging.
Added function to Reflection for getting a generic method info when multiple functions with the same name exist.
Added Unity physics module dependency for a hook that required the Collision type.
Fixed bug in MonsterItemsAPI that occured when the ItemDropAPI drop lists differed from the MonsterItemsAPI drop lists.