Implement RecalculateStatsAPI, an API provided by TILER2 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Very fast, and based. |
|
@ThinkInvis Since your tiler2 library is GPL licensed, we need explicit permission or to copy the license to include this. |
|
I've talked to him about it in the R2API channel, you can see that he gave explicit permission there. |
|
All good 👍 |
|
Great work, thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a migration of TILER2's StatHook to R2API. I believe it's an amazing implementation given that it lets mod developers add a hook easily with their modifications. Another reason for this is so that there's a unified approach when dealing with RecalculateStats.
Big thanks to ThinkInvisible.