-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added to readme. #297
Merged
tristanmcpherson
merged 11 commits into
risk-of-thunder:master
from
Phedg1Studios:master
Jul 19, 2021
Merged
Added to readme. #297
tristanmcpherson
merged 11 commits into
risk-of-thunder:master
from
Phedg1Studios:master
Jul 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd everything in the ItemDrop folder.
…us's feedback. Removed all work supporting balancing pickups of any tier in any tier of drop list when using the artifact of command. Removed support for allowing pickups of any tier in any tier of drop list. Rewrote the front end of ItemDropAPI and MonsterItemsAPI to be in line with these changes. Added simple functionality to support adding unique pickups (elite equipment, captain's defense matrix) to regular drop lists. Rewrote most of MonsterItemsAPI to support this feature. The reference catalogue is now populated after all content packs have been loaded. The original drop lists will now be updated for each run, as they can change with achievement unlocks in a single session.
Implemented a hook for the generic method Xoroshiro128Plus.NextElementUniform. All credit goes to iDeathHD for this. Removed all "replace with knwon good drop lists" implementations. Removed all code that would generate drop lists containing PickupIndex.none instead of empty lists. Removed all code checking if a drop list only contains PickupIndex.none. Removed some redundant variables. Fixed ArenaMissionController from potentially giving no rewards.
Added instructions for mods that rely on the ItemDropAPI to ease the transition. Added check to special equipment to determine if it is unlocked. Fixed application of changes to drop lists in regards to special pickups. Added an event to Catalog after the special lists are generated.
# Conflicts: # R2API/ItemDrop/Catalog.cs # R2API/ItemDrop/DropList.cs # R2API/ItemDrop/DropOdds.cs # R2API/ItemDrop/InteractableCalculator.cs # R2API/ItemDropAPI.cs # R2API/MonsterItemsAPI.cs
Added missing reflection to DropList. Fixed error caused if an EliteDef did not have an associated equipment. InteractablesAPI will now clear operations at the start of each run. Fixed MonsterItemsAPI creating insufficient entries in its GenerateAvailableItemsSet method.
Listed two significant api changes and a link to some new documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listed two significant api changes and a link to some new documentation.
This only covers my contribution to this update, I am not across what other people have added. Someone else will have to follow up on that.