Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CombineHashCode return the same result on arrays of different order #381

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix CombineHashCode return the same result on arrays of different order #381

merged 1 commit into from
Apr 8, 2022

Conversation

DemoJameson
Copy link
Contributor

the previous algorithm resulted in the following hashcodes being equal

var hashcode1 = Reflection.CombineHashCode(new Type[]{typeof(string), typeof(int), typeof(string), typeof(int)});
var hashcode2 = Reflection.CombineHashCode(new Type[]{typeof(string), typeof(string), typeof(int), typeof(int)});

@DemoJameson DemoJameson marked this pull request as draft April 8, 2022 15:57
@DemoJameson DemoJameson marked this pull request as ready for review April 8, 2022 16:08
@tristanmcpherson
Copy link
Member

Good catch

@tristanmcpherson tristanmcpherson merged commit 071bfd8 into risk-of-thunder:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanmcpherson tristanmcpherson tristanmcpherson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DemoJameson @tristanmcpherson