Refactor mongodb module to align with other modules #1
+65
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
shmsr
commented
Apr 24, 2023
| if parts := strings.SplitN(host, "://", 2); len(parts) != 2 { | ||
| host = "mongodb://" + host // add scheme | ||
| } | ||
| if err := clientOptions.ApplyURI(host).Validate(); err != nil { |
There was a problem hiding this comment.
ApplyURI is purposedly put here because as per the documentation, any methods on clientOptions i.e, of SetXXX form overrides the URI parameters (if any) and vice-versa. So it would give the user freedom to set as desired parameters using the URI itself and it overrides the values of the fields that were set using SetXXX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing and debugging the new changes made to beats, we found that how clientOptions was initialized twice and lots of operations were happening for every
Fetchalthough it's the same across all metricsets. Also the naming of the structs were off.mongodb module's implementation was not as standard as other modules like beat, aerospike, etc. So, as per Boy Scout Rule, it was important that we should ideally first fix this problem so that no technical debt is there when we are making the actual change. With the new changes, it was easier to do the new changes related to adding multi-host support for mongodb module. Also, these changes fixes the issues that we found during testing.
cc: @ritalwar