Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve trakt data fetch error #987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdaptCharm
Copy link

@AdaptCharm AdaptCharm commented Feb 2, 2025

Pull Request Check List

Partially resolves: #959

  • Listrr issue still present.

  • Added tests for changed code.

  • Updated documentation for changed code.

Description:

Summary by CodeRabbit

  • Bug Fixes
    • Improved consistency in how results are formatted for reliable display.
    • Adjusted pagination to consistently limit the number of items shown.
  • Chores
    • Applied minor formatting updates for improved consistency.

Copy link
Contributor

coderabbitai bot commented Feb 2, 2025

Walkthrough

This pull request updates the _fetch_data method within the TraktAPI class. The update ensures that if response.data is not already a list, it is wrapped in one so that subsequent processing receives a consistent data type. Additionally, the method now slices the aggregated all_data list to respect a specified limit. A minor formatting change, adding a newline at the end of the file, is also included.

Changes

File(s) Change Summary
src/.../trakt_api.py Modified _fetch_data in TraktAPI: wraps non-list response.data into a list; updates pagination logic to slice all_data when limit is reached; added newline at file end.

Sequence Diagram(s)

sequenceDiagram
    participant T as TraktAPI
    participant R as API Response

    T->>R: Request data
    alt response.data is a list
        R-->>T: Return list data
    else response.data is not a list
        R-->>T: Return single data item
        T->>T: Wrap data into a list
    end
    T->>T: Append data to all_data
    T->>T: Slice all_data to enforce limit (if needed)
Loading

Assessment against linked issues

Objective (Issue) Addressed Explanation
#959: docker dev listrr - types.SimpleNamespace object has no attribute 'get' Changes apply to TraktAPI and do not impact listrr functionality.

Poem

I'm a coding rabbit, hopping with delight,
Wrapping data snugly, keeping lists bright.
Fetching responses with a twist so fine,
Slicing limits neatly, every single time.
With each new change, I bound and play,
Celebrating tidy code all day!
🐰✨

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/program/apis/trakt_api.py (1)

81-81: Consider optimizing pagination to reduce API calls.

While the limit enforcement is correct, we could optimize the pagination to avoid fetching more data than necessary. Consider adjusting the page size based on the limit parameter.

Apply this diff to optimize the pagination:

 def _fetch_data(self, url, params):
     """Fetch paginated data from Trakt API with rate limiting."""
     all_data = []
     page = 1
+    # Default page size in Trakt API is 10
+    page_size = 10
+    if "limit" in params:
+        # Adjust page size to minimize API calls
+        params["page_size"] = min(params["limit"], page_size)

     while True:
         try:
             response = self.request_handler.execute(HttpMethod.GET, url, params={**params, "page": page})
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a18a66c and debaa53.

📒 Files selected for processing (1)
  • src/program/apis/trakt_api.py (2 hunks)
🔇 Additional comments (1)
src/program/apis/trakt_api.py (1)

74-74: LGTM! Good defensive programming.

The change ensures consistent data type handling by wrapping non-list responses in a list, preventing potential errors when the API returns a single item.

@AyushSehrawat AyushSehrawat changed the title Resolve trakt data fetch error fix: resolve trakt data fetch error Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker dev listrr - types.SimpleNamespace' object has no attribute 'get'
2 participants