fix leadership election TTL issue #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a glaring oversight in the leader elector code, it actually uses the same interval for both the internal ticker (for re-electing itself) and for extending the TTL in the database. These timers and queries are of course not instantaneous, which means a perfectly functional leader can fail to re-elect itself cleanly. Extensive test coverage on the elector to come in subsequent PRs. Fixes #216.
bgentry
force-pushed
the
bg-fix-elector-ttl
branch
from
a0baee1 to
7c7ac98
Compare
brandur
approved these changes
Feb 19, 2024
brandur
added a commit
that referenced
this pull request
Feb 19, 2024
Prepare a new release for `v0.0.21`, with the most important change contained being #217, which fixes a bug in the leadership election code. I know I said I'd switch to minor version releases after `v0.0.20`, but since this version is largely a hotfix with a small change, I did another patch.
Merged
brandur
added a commit
that referenced
this pull request
Feb 19, 2024
Prepare a new release for `v0.0.21`, with the most important change contained being #217, which fixes a bug in the leadership election code. I know I said I'd switch to minor version releases after `v0.0.20`, but since this version is largely a hotfix with a small change, I did another patch.
brandur
added a commit
that referenced
this pull request
Feb 19, 2024
Follows up #217 to add TTL padding on the elector's initial election attempt in addition to adding it to reelection attempts as was done previously. We move the TTL calculation to a struct variable for easier and more foolproof access, and to be able put a comment on it.
brandur
added a commit
that referenced
this pull request
Feb 19, 2024
Follows up #217 to add TTL padding on the elector's initial election attempt in addition to adding it to reelection attempts as was done previously. We move the TTL calculation to a struct variable for easier and more foolproof access, and to be able put a comment on it.
brandur
added a commit
that referenced
this pull request
Feb 19, 2024
Follows up #217 to add TTL padding on the elector's initial election attempt in addition to adding it to reelection attempts as was done previously. We move the TTL calculation to a struct variable for easier and more foolproof access, and to be able put a comment on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a glaring oversight in the leader elector code, it actually uses the same interval for both the internal ticker (for re-electing itself) and for extending the TTL in the database. These timers and queries are of course not instantaneous, which means a perfectly functional leader can fail to re-elect itself cleanly.
Extensive test coverage on the elector to come in subsequent PRs.
Fixes #216.