Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JobCleaner timeout dynamically #576

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

PumpkinSeed
Copy link
Contributor

Suggested implementation of #575

@bgentry
Copy link
Contributor

bgentry commented Sep 2, 2024

@PumpkinSeed thanks for taking a stab at this! I think we will end up needing to add some test coverage for it, but otherwise it looks pretty much spot on.

Could you please add yourself to the CLA here before we move forward on this? https://github.com/riverqueue/rivercla

@PumpkinSeed
Copy link
Contributor Author

@bgentry I wrote a specific test for this case.

I already did the CLA in the past.

@bgentry
Copy link
Contributor

bgentry commented Sep 3, 2024

D’oh, sorry I missed that 🤦🏼‍♂️ newborn sleep deprivation kicking in over here 😅 Will sync with @brandur on this shortly and hopefully get it merged, thank you!

@PumpkinSeed
Copy link
Contributor Author

Hi, do you have any update on this? @bgentry

@bgentry
Copy link
Contributor

bgentry commented Sep 19, 2024

Hi @PumpkinSeed, really sorry about the delay on this. I should be able to get it merged today and shipped in the next release.

@bgentry bgentry force-pushed the I575-jobcleaner-deadline branch from 8a5118b to ab57b0f Compare September 20, 2024 03:49
@bgentry
Copy link
Contributor

bgentry commented Sep 20, 2024

@brandur I did some cleanup on this one and I think it should be suitable for now, but please feel free to take a look before it ships!

@bgentry bgentry enabled auto-merge (squash) September 20, 2024 03:51
@bgentry bgentry disabled auto-merge September 20, 2024 03:51
@bgentry bgentry enabled auto-merge (squash) September 20, 2024 03:52
@bgentry bgentry merged commit 652d002 into riverqueue:master Sep 20, 2024
14 checks passed
@PumpkinSeed PumpkinSeed deleted the I575-jobcleaner-deadline branch September 20, 2024 12:38
brandur added a commit that referenced this pull request Sep 21, 2024
An infinitesimal change to add a missing pull request link for the
change in #576.
bgentry pushed a commit that referenced this pull request Oct 5, 2024
An infinitesimal change to add a missing pull request link for the
change in #576.
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
The JobCleaner maintenance process had a hardcoded 30 second timeout. While this is
plenty long enough for most installations, in certain very large job tables this may not
be enough time to run a single round of the query.

This makes the timeout customizable via a Client config.

---------

Co-authored-by: Blake Gentry <blakesgentry@gmail.com>
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
An infinitesimal change to add a missing pull request link for the
change in riverqueue#576.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants