Fix riverdatabasesql nil values in bytea #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg-fix-dbsql-nil-bytea
branch
from
a6f5502 to
547ac05
Compare
bgentry
changed the title
bgentry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #650 illustrates, the riverdatabasesql driver has issues with encoding arrays of byte arrays (
bytea[]) and just byte arrays in general because the underlying pq implementation used by sqlc doesn't differentiate between nil vs empty slices. Fix this with a custom type.The previously written test coverage (first commit) was failing, and gets fixed by this change.
Fixes #650.