Skip to content

Commit

Permalink
build release binaries with NODE_ENV and VITE_RIVER_API_BASE_URL
Browse files Browse the repository at this point in the history
Fixes #60.
  • Loading branch information
bgentry committed Jun 23, 2024
1 parent 698220a commit c436db5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ jobs:

release:
name: Release
env:
NODE_ENV: production
VITE_RIVER_API_BASE_URL: /api
permissions:
contents: write
runs-on: ubuntu-latest
Expand All @@ -218,14 +221,15 @@ jobs:
with:
cache: "npm"
cache-dependency-path: ui/package-lock.json
node-version: current
node-version: "20.12.2"

- name: Install dependencies
run: npm install
shell: sh
working-directory: ui

- name: Build UI bundle
run: npm run build
run: npm exec vite build
working-directory: ui

# We use `export` below so that we can reuse the variables in the command
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fix prebuilt binaries to correctly set required envs before JS build step. [PR #61](https://github.com/riverqueue/riverui/pull/61).

## [0.1.0] - 2024-06-22

### Added
Expand Down

0 comments on commit c436db5

Please sign in to comment.