Dynamic path prefix #115
Merged
Dynamic path prefix #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg-dynamic-path
branch
2 times, most recently
from
51ad34a to
0e8a045
Compare
brandur
approved these changes
Aug 26, 2024
bgentry
force-pushed
the
bg-dynamic-path
branch
from
0e8a045 to
c2b34cc
Compare
|
Beautiful, just tested this with the latest Docker container from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the UI assets to be built and have a dynamic path prefix injected at runtime. Also switches us to a new dev setup.
This was quite difficult to sort out, but fortunately https://github.com/amir20/dozzle/ had already blazed the trail here.
With these changes, we should be able to dramatically simplify the existing steps for #107, and solve it completely for all
go getusers if we're willing to publish pre-built release artifacts. Unlike with riverpro, these could be made publicly available and cached permanently by goproxy servers, so the hosting burden would be minimal.Fixes #114.