Skip to content

Commit

Permalink
chore: fix region not being used in actor sdk (#1623)
Browse files Browse the repository at this point in the history
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
  • Loading branch information
NathanFlurry committed Dec 13, 2024
1 parent 2659afa commit f5e2741
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/toolchain/toolchain/src/tasks/deploy/js.rs
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,6 @@ async fn upload_bundle(
task.log(format!("{err:?}"));
}
complete_res.context("complete_res")?;

Ok(prepare_res.build)
}
9 changes: 4 additions & 5 deletions sdks/actors/client/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,12 @@ export class Client {
// Build create config
let create: CreateRequest | undefined = undefined;
if (!opts?.noCreate) {
create = create ?? {
create = {
// Default to the same tags as the request
tags: tags,
tags: opts?.create?.tags ?? tags,
// Default to the chosen region
region: opts?.create?.region ?? (await this.#regionPromise)?.id,
};

// Default to the chosen region
if (!create.region) create.region = (await this.#regionPromise)?.id;
}

logger().debug("get actor", { tags, parameters: opts?.parameters, create });
Expand Down

0 comments on commit f5e2741

Please sign in to comment.