Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): disable vpa for prometheus & traffic server #817

Merged

Conversation

NathanFlurry
Copy link
Member

Currently VPAs cause these issues:

  • Autoscaling doesn't play nice with Karpenter
  • Prometheus takes a long time to replay the WAL, which causes frequent Prometheus outages
  • Prometheus is better managed manually, since the load varies dramatically

@NathanFlurry NathanFlurry requested a review from MasterPtato May 29, 2024 18:06
Copy link
Contributor

graphite-app bot commented May 29, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

NathanFlurry commented May 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@MasterPtato MasterPtato force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 41ae17b to 6ead484 Compare May 31, 2024 19:41
@MasterPtato MasterPtato force-pushed the 05-29-chore_infra_disable_vpa_for_prometheus_traffic_server branch from 48784c7 to ac7366a Compare May 31, 2024 19:41
@MasterPtato MasterPtato force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 6ead484 to 7ee05b8 Compare May 31, 2024 19:48
@MasterPtato MasterPtato force-pushed the 05-29-chore_infra_disable_vpa_for_prometheus_traffic_server branch from ac7366a to 90355bc Compare May 31, 2024 19:49
Copy link
Contributor

graphite-app bot commented May 31, 2024

Merge activity

@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 7ee05b8 to c52517b Compare May 31, 2024 21:33
NathanFlurry added a commit that referenced this pull request May 31, 2024
Currently VPAs cause these issues:

- Autoscaling doesn't play nice with Karpenter
- Prometheus takes a long time to replay the WAL, which causes frequent Prometheus outages
- Prometheus is better managed manually, since the load varies dramatically
@NathanFlurry NathanFlurry force-pushed the 05-29-chore_infra_disable_vpa_for_prometheus_traffic_server branch from 90355bc to 2c1656c Compare May 31, 2024 21:34
Currently VPAs cause these issues:

- Autoscaling doesn't play nice with Karpenter
- Prometheus takes a long time to replay the WAL, which causes frequent Prometheus outages
- Prometheus is better managed manually, since the load varies dramatically
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from c52517b to 6350c72 Compare May 31, 2024 22:06
@NathanFlurry NathanFlurry force-pushed the 05-29-chore_infra_disable_vpa_for_prometheus_traffic_server branch from 2c1656c to 5da29a4 Compare May 31, 2024 22:07
@NathanFlurry NathanFlurry changed the base branch from 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order to main May 31, 2024 22:46
@graphite-app graphite-app bot merged commit 5da29a4 into main May 31, 2024
7 of 10 checks passed
@graphite-app graphite-app bot deleted the 05-29-chore_infra_disable_vpa_for_prometheus_traffic_server branch May 31, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants