-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(infra): disable vpa for prometheus & traffic server #817
Merged
graphite-app
merged 1 commit into
main
from
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
May 31, 2024
Merged
chore(infra): disable vpa for prometheus & traffic server #817
graphite-app
merged 1 commit into
main
from
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This was referenced May 29, 2024
Merged
NathanFlurry
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 29, 2024 18:29
d572b8b
to
7d8b3ad
Compare
NathanFlurry
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 29, 2024 18:29
2d13b54
to
a1a7dbe
Compare
This was referenced May 29, 2024
Merged
MasterPtato
approved these changes
May 29, 2024
This was referenced May 30, 2024
This was referenced May 30, 2024
NathanFlurry
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 31, 2024 00:42
7d8b3ad
to
41ae17b
Compare
NathanFlurry
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 31, 2024 00:43
a1a7dbe
to
48784c7
Compare
MasterPtato
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 31, 2024 19:41
41ae17b
to
6ead484
Compare
MasterPtato
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 31, 2024 19:41
48784c7
to
ac7366a
Compare
MasterPtato
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 31, 2024 19:48
6ead484
to
7ee05b8
Compare
MasterPtato
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 31, 2024 19:49
ac7366a
to
90355bc
Compare
This was referenced May 31, 2024
Merge activity
|
NathanFlurry
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 31, 2024 21:33
7ee05b8
to
c52517b
Compare
NathanFlurry
added a commit
that referenced
this pull request
May 31, 2024
Currently VPAs cause these issues: - Autoscaling doesn't play nice with Karpenter - Prometheus takes a long time to replay the WAL, which causes frequent Prometheus outages - Prometheus is better managed manually, since the load varies dramatically
NathanFlurry
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 31, 2024 21:34
90355bc
to
2c1656c
Compare
Currently VPAs cause these issues: - Autoscaling doesn't play nice with Karpenter - Prometheus takes a long time to replay the WAL, which causes frequent Prometheus outages - Prometheus is better managed manually, since the load varies dramatically
NathanFlurry
force-pushed
the
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
branch
from
May 31, 2024 22:06
c52517b
to
6350c72
Compare
NathanFlurry
force-pushed
the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
from
May 31, 2024 22:07
2c1656c
to
5da29a4
Compare
NathanFlurry
changed the base branch from
05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order
to
main
May 31, 2024 22:46
graphite-app
bot
deleted the
05-29-chore_infra_disable_vpa_for_prometheus_traffic_server
branch
May 31, 2024 22:47
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently VPAs cause these issues: