Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gracfully delete secondary dns record #828

Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix: gracfully delete secondary dns record #828

merged 1 commit into from
Jun 1, 2024

Conversation

MasterPtato
Copy link
Contributor

Changes

This was referenced May 30, 2024
Merged
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 30, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced May 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@MasterPtato MasterPtato mentioned this pull request May 30, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request May 30, 2024
Merged
This was referenced May 30, 2024
Merged
Merged
Merged
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

This was referenced May 30, 2024
Merged
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from fea2e3f to 309ac88 Compare May 31, 2024 00:43
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from 1cc2563 to 5b00eb1 Compare May 31, 2024 00:43
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from 309ac88 to 9956eed Compare May 31, 2024 00:49
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from 5b00eb1 to 90c3525 Compare May 31, 2024 00:49
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from 9956eed to e0612b5 Compare May 31, 2024 01:00
@MasterPtato MasterPtato force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from e0612b5 to b10065a Compare May 31, 2024 19:42
@MasterPtato MasterPtato force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from 90c3525 to 1d504fe Compare May 31, 2024 19:42
@MasterPtato MasterPtato requested a review from NathanFlurry May 31, 2024 19:42
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from b10065a to 4f65dc2 Compare May 31, 2024 19:49
@MasterPtato MasterPtato force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from 1d504fe to 8827e26 Compare May 31, 2024 19:50
This was referenced May 31, 2024
Merged
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 31, 2024 •
edited
Loading

Merge activity

@MasterPtato MasterPtato force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from 4f65dc2 to 7661f75 Compare May 31, 2024 22:26
@MasterPtato MasterPtato force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from 8827e26 to e4c31e0 Compare May 31, 2024 22:26
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@MasterPtato
fix: gracfully delete secondary dns record (#828)
94cc2ae 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_delete_dns_record_after_failure_to_create branch from 7661f75 to 35fc6fe Compare June 1, 2024 08:35
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_gracfully_delete_secondary_dns_record branch from e4c31e0 to 94cc2ae Compare June 1, 2024 08:36
@NathanFlurry NathanFlurry changed the base branch from 05-30-fix_cluster_delete_dns_record_after_failure_to_create to main June 1, 2024 08:52
@graphite-app graphite-app bot merged commit 94cc2ae into main Jun 1, 2024
7 of 10 checks passed
@graphite-app graphite-app bot deleted the 05-30-fix_gracfully_delete_secondary_dns_record branch June 1, 2024 08:54
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry