Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster): handle failed tls issuing gracefully #825

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(cluster): handle failed tls issuing gracefully #825

merged 1 commit into from
May 31, 2024

Conversation

NathanFlurry
Copy link
Member

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato May 30, 2024 03:45
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 30, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced May 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented May 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@NathanFlurry NathanFlurry mentioned this pull request May 30, 2024
Merged
MasterPtato
MasterPtato reviewed May 30, 2024
View reviewed changes
svc/pkg/cluster/standalone/fix-tls/src/lib.rs
domain_job,
vec![
// TODO: Remove this
format!("i-see-you-skid.{domain_job}"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

This was referenced May 30, 2024
Merged
Merged
Merged
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 05-30-chore_update_default_builds branch from e54556a to 78b9225 Compare May 31, 2024 00:43
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch from c49b1c3 to 3c7368b Compare May 31, 2024 00:43
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request May 31, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-30-chore_update_default_builds branch from 78b9225 to e5a58ad Compare May 31, 2024 19:42
@MasterPtato MasterPtato force-pushed the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch from 39388a0 to 07dd5bb Compare May 31, 2024 19:42
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-30-chore_update_default_builds branch from e5a58ad to 456cac8 Compare May 31, 2024 19:49
@MasterPtato MasterPtato force-pushed the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch from 07dd5bb to 69b57e9 Compare May 31, 2024 19:49
This was referenced May 31, 2024
Merged
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented May 31, 2024 •
edited
Loading

Merge activity

@NathanFlurry NathanFlurry force-pushed the 05-30-chore_update_default_builds branch from 456cac8 to 8f075c2 Compare May 31, 2024 21:36
NathanFlurry added a commit that referenced this pull request May 31, 2024
@NathanFlurry
fix(cluster): handle failed tls issuing gracefully (#825)
237c94c 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch from 69b57e9 to 237c94c Compare May 31, 2024 21:36
@NathanFlurry
fix(cluster): handle failed tls issuing gracefully (#825)
9aa424b 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-30-chore_update_default_builds branch from 8f075c2 to a6d5854 Compare May 31, 2024 22:09
@NathanFlurry NathanFlurry force-pushed the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch from 237c94c to 9aa424b Compare May 31, 2024 22:10
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry changed the base branch from 05-30-chore_update_default_builds to main May 31, 2024 22:52
An error occurred while trying to automatically change base from 05-30-chore_update_default_builds to main May 31, 2024 22:52
@graphite-app graphite-app bot merged commit 9aa424b into main May 31, 2024
7 of 10 checks passed
@graphite-app graphite-app bot deleted the 05-30-fix_cluster_handle_failed_tls_issuing_gracefully branch May 31, 2024 22:52
@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato