Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compile errors in manager #1291

Closed
wants to merge 1 commit into from
Closed

fix: fix compile errors in manager #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common/metrics/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ lazy_static = "1.4"
prometheus = "0.13"
rivet-config = { version = "0.1.0", path = "../config" }
rivet-env = { version = "0.1.0", path = "../env" }
tokio = "1.41.0"
tokio = "1.36.0"
tracing = "0.1"

14 changes: 13 additions & 1 deletion packages/infra/pegboard/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/infra/pegboard/manager/src/ctx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ impl Ctx {
let runner_socket = tokio::spawn(async move {
tracing::warn!(port=%RUNNER_PORT, "listening for runner sockets");
let listener = match TcpListener::bind(("0.0.0.0", RUNNER_PORT)).await {
Ok(x) => x,
Result::Ok(x) => x,
Err(err) => {
tracing::error!(host = "0.0.0.0", port = ?RUNNER_PORT, "failed to bind pegboard manager server");

Expand Down
2 changes: 1 addition & 1 deletion packages/infra/pegboard/manager/src/metrics/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub async fn run_standalone() {
let server = match Server::try_bind(&addr) {
Ok(x) => x,
Err(err) => {
tracing::error!(?host, ?port, ?err, "failed to bind pegboard metrics server");
tracing::error!(?addr, ?err, "failed to bind pegboard metrics server");

// TODO: Find cleaner way of crashing entire program
// Hard crash program since a server failing to bind is critical
Expand Down
Loading