Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cluster): dc-get column mismatch #958

Merged
merged 1 commit into from
Jun 30, 2024
Merged

fix(cluster): dc-get column mismatch #958

merged 1 commit into from
Jun 30, 2024

Conversation

NathanFlurry
Copy link
Member

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato June 27, 2024 13:58
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jun 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@NathanFlurry NathanFlurry mentioned this pull request Jun 27, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 27, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry
Copy link
Member Author

Looks like this isn't a problem after all, but making pr for cleanup regardless

@NathanFlurry NathanFlurry mentioned this pull request Jun 27, 2024
Merged
MasterPtato
MasterPtato approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of properties matters for row deserialization? I had no idea

@MasterPtato MasterPtato force-pushed the 06-26-fix_better_uptime_handle_null_verify_ssl branch from 193b1ea to 4e16980 Compare June 27, 2024 18:19
@MasterPtato MasterPtato force-pushed the 06-27-fix_cluster_dc-get_column_mismatch branch from 2c4079b to 93a5d31 Compare June 27, 2024 18:19
@MasterPtato MasterPtato mentioned this pull request Jun 27, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request Jun 29, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 30, 2024 •
edited
Loading

Merge activity

@NathanFlurry
fix(cluster): dc-get column mismatch (#958)
53e276a 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 06-26-fix_better_uptime_handle_null_verify_ssl branch from 4e16980 to e9d8edb Compare June 30, 2024 22:02
@NathanFlurry NathanFlurry force-pushed the 06-27-fix_cluster_dc-get_column_mismatch branch from 93a5d31 to 53e276a Compare June 30, 2024 22:02
@NathanFlurry NathanFlurry changed the base branch from 06-26-fix_better_uptime_handle_null_verify_ssl to main June 30, 2024 22:06
@graphite-app graphite-app bot merged commit 53e276a into main Jun 30, 2024
6 of 10 checks passed
@graphite-app graphite-app bot deleted the 06-27-fix_cluster_dc-get_column_mismatch branch June 30, 2024 22:07
@github-actions github-actions bot mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato