Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/utils] mem conversion float err #72

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

abhinavDhulipala
Copy link
Collaborator

@abhinavDhulipala abhinavDhulipala commented Jun 19, 2024

Change the datatype for mem string conversion. The map shouldn't really have ever had int value types as we cast and return a float anyway.

resolves #71

Copy link

@codeknight03 codeknight03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I am concerned about with this change is the main branch worked on one linux system and not on the other, so are we sure changing this is the way to go ?

@abhinavDhulipala
Copy link
Collaborator Author

I'm pretty sure the reason it failed is because the golang type int means different things to different platforms, based in the kernel. But if we use int32/64 or float32/64 golang will make sure to use a consistent underlying data type. Please test out the branch by installing and building the branch.

@abhinavDhulipala abhinavDhulipala merged commit cd27134 into main Jun 22, 2024
4 checks passed
@abhinavDhulipala abhinavDhulipala deleted the util-int64 branch June 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Fails: go install fails with error in utils.go
2 participants