Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RzIL] Add lifter for Armv8 AArch64 #2354

Merged
merged 100 commits into from
Mar 27, 2022
Merged

[RzIL] Add lifter for Armv8 AArch64 #2354

merged 100 commits into from
Mar 27, 2022

Conversation

thestr4ng3r
Copy link
Member

@thestr4ng3r thestr4ng3r commented Feb 22, 2022 •
edited
Loading

SQUASH ME

@thestr4ng3r thestr4ng3r force-pushed the il-arm64 branch 2 times, most recently from 9bdb4e9 to 26dfbe1 Compare February 23, 2022 13:48
@thestr4ng3r thestr4ng3r mentioned this pull request Feb 24, 2022
Open
38 tasks
@thestr4ng3r thestr4ng3r force-pushed the il-arm64 branch 12 times, most recently from b53476d to d39d0ba Compare March 3, 2022 19:04
@thestr4ng3r thestr4ng3r force-pushed the il-arm64 branch 4 times, most recently from 4f38a23 to 27699eb Compare March 8, 2022 14:41
XVilka
XVilka requested changes Mar 9, 2022
View reviewed changes
librz/analysis/arch/arm/arm_il32.c Outdated Show resolved Hide resolved
librz/analysis/arch/arm/arm_il64.c Outdated Show resolved Hide resolved
@thestr4ng3r thestr4ng3r mentioned this pull request Mar 9, 2022
Merged
5 tasks
@thestr4ng3r thestr4ng3r force-pushed the il-arm64 branch 2 times, most recently from 8f27e66 to cdfece8 Compare March 14, 2022 12:55
XVilka
XVilka reviewed Mar 19, 2022
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the code point of view. Amazing job, as always! 💯

librz/analysis/arch/arm/arm_il64.c Show resolved Hide resolved
@XVilka XVilka added this to the 0.4.0 milestone Mar 19, 2022
@thestr4ng3r thestr4ng3r force-pushed the il-arm64 branch 2 times, most recently from 78a8a16 to 1ddfdb5 Compare March 23, 2022 12:14
@thestr4ng3r thestr4ng3r marked this pull request as ready for review March 26, 2022 13:51
@thestr4ng3r thestr4ng3r requested a review from XVilka March 26, 2022 13:51
@thestr4ng3r thestr4ng3r changed the title [RzIL] AArch64 Lifter [RzIL] Add lifter for Armv8 AArch64 Mar 26, 2022
@thestr4ng3r thestr4ng3r requested a review from wargio March 26, 2022 18:08
@thestr4ng3r thestr4ng3r requested a review from wargio March 26, 2022 18:14
wargio
wargio reviewed Mar 26, 2022
View reviewed changes
librz/analysis/p/analysis_arm_cs.c
@@ -1755,7 +1755,7 @@ static int analysis_op(RzAnalysis *a, RzAnalysisOp *op, ut64 addr, const ut8 *bu
return -1;
}
}
int haa = hackyArmAnal(a, op, buf, len);
int haa = hackyArmAnal(a, op, buf, len); // TODO: disable this for capstone 5 after testing that everything works
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR, but this function name shall be renamed.

@thestr4ng3r thestr4ng3r merged commit 8414d22 into dev Mar 27, 2022
@thestr4ng3r thestr4ng3r deleted the il-arm64 branch March 27, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio wargio approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
ARM RzAnalysis
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thestr4ng3r @XVilka @wargio