Expose APIs for rz-solver #4648
Merged
+667
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
requested changes
Sep 24, 2024
giridharprasath
force-pushed
the
rop_improvements
branch
from
5e2f3ca
to
af1e995
Compare
Agree 👍 , Will track it under another issue |
|
APIs used by the rz-solver: test-rop-solver.c |
|
@giridharprasath ping? |
|
@giridharprasath please rebase and add a unit test for this. Then we can merge. |
|
@XVilka I will be wrapping this and push the changes today. |
Got a little late, Will commit the changes today |
giridharprasath
force-pushed
the
rop_improvements
branch
from
b513c4c
to
7e0aa44
Compare
giridharprasath
requested review from
wargio,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
wargio
reviewed
Oct 13, 2024
* Add new APIs for compound OPs * Add new testcases for compound op * Fix testcases for rop constraint * Refactor rop constraint handling
giridharprasath
force-pushed
the
rop_improvements
branch
from
39bb19c
to
3aeef0a
Compare
XVilka
approved these changes
Oct 15, 2024
wargio
reviewed
Oct 15, 2024
wargio
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Exposing some APIs required for rz-solver
#4563
...
Test plan
...
Closing issues
...