Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect stderr to stdout via -1; Unbreak dk 9 test #4664

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 11, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr adds a -1 flag to Rizin to redirect stderr to stdout, so that the dk 9 test can be unbroken.

Test plan

The addition is appropriate. All builds are green.

Closing issues

...

@kazarmy kazarmy marked this pull request as ready for review October 11, 2024 14:29
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm ok with this, but the PR should be renamed to Fix sig 9 on child and introduce stderr redirection via -1 (or similar)

@kazarmy kazarmy changed the title -1: Redirect stderr to stdout Redirect stderr to stdout via -1; Unbreak dk 9 test Oct 11, 2024
@kazarmy
Copy link
Member Author

kazarmy commented Oct 11, 2024

Ok

@kazarmy kazarmy merged commit 5ee08f7 into rizinorg:dev Oct 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants