Aweful RzAsm <-> RzAnalysis pointer sharing and Hexagon unify #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because static values are no longer allowed, it has to be sure that the 'user' pointer for the config value setter is always the plugin data. So the plugin can change its internal state, according to the configuration value. This was not possible before. Also it adds a seperated hash map for plugin values. So they are logically more separated.
Also resolves the problems with not knowing what is a valid instruction and which one not. Leads to way mor stability in decoding.
…() in analysis_hexagon.c
Rot127
requested review from
wargio,
ret2libc,
XVilka,
kazarmy and
thestr4ng3r
as code owners
5 tasks
XVilka
reviewed
Oct 13, 2024
wargio
reviewed
Oct 14, 2024
wargio
approved these changes
Oct 14, 2024
Co-authored-by: Giovanni <561184+wargio@users.noreply.github.com>
Rot127
force-pushed
the
dist-fuzz-hexagon-unify
branch
from
cff6a87
to
6d0db7b
Compare
XVilka
approved these changes
Oct 14, 2024
wargio
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Hacks
Attempt to share pointers between
RzAsmandRzAnalysiswithout anyRzArch.The assumption made here is that
RzAsmis always initialized. Also without anyRzAnalysis. ButRzAnalysisis never initialized without a companionRzAsm.Hence a plugin requiring a common state, always accesses
RzAsm->plugin_data, no matter if it was called fromRzAnalysisorRzAsm.RzAnalysisholds the file buffer. So if this one is present, the plugin should initialize a buffer around it. If it is not there, it should make a byte buffer around the bytes passed to the function.This mimics future behavior of
RzArchwhich will get either anIOorBytesbuffer.Plugin configs
With this change there is also the need to refactor the plugin specific configs.
I designed them badly before. And they couldn't be used by a plugin without a static variable.
Plugin specific configs are hold now in a hash mpa in RzCore. The reason to have them separately and not in the
RzCore->configis because plugins can be the owner of them. Meaning theconfig_setfunctions will pass a pointer with the plugin state. Not the core state. This is required if plugins have specific configuration options they need to know, but have no access toRzCoreto get them.It adds luckily only a few more lines to handle them in
cmd_eval.cand for the auto-complete.Hexagon changes
RzAsm->plugin_data.Test plan
For plugin configs
Otherwise: all green with fuzz-dist.
Closing issues
None. Probably opens a few more.