Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove macos-12 build #4676

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ci: Remove macos-12 build #4676

merged 1 commit into from
Oct 17, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 17, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Both Intel Macs and the GitHub macos-12 image are going the way of the dodo and since there is woodpecker for mac arm builds, this pr removes the macos-meson-clang-tests build.

Test plan

The removal is appropriate.

Closing issues

...

@kazarmy kazarmy merged commit f2a6d2a into rizinorg:dev Oct 17, 2024
40 checks passed
@kazarmy kazarmy mentioned this pull request Oct 20, 2024
Closed
3 tasks
kazarmy added a commit to kazarmy/rizin that referenced this pull request Oct 22, 2024
@kazarmy
Revert "ci: Remove macos-12 build (rizinorg#4676)"
8039ccc 
This reverts commit f2a6d2a.
kazarmy added a commit that referenced this pull request Oct 23, 2024
@kazarmy
ci: Reinstate macos-meson-clang-tests build on macos-13 (#4682)
f641480 
* Revert "Upgrade build-osx-pkg build to macos-14 (#4677)"
* Revert "ci: Remove macos-12 build (#4676)"
* Upgrade macos builds to macos-13
* Add fetch-depth: 2 to build-osx-pkg build
* Add -Wno-deprecated-non-prototype flag to `macos-meson-clang-tests` build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazarmy @wargio