Wrong allOf behaviour

[AlimovSV]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

What theme are you using?

core

Version

4.2.0

Current Behavior

Expected Behavior

Should be valid

Steps To Reproduce

Example

• Playground
• AJV validator

Schema

{
  "type": "object",
  "properties": {
    "data": {
      "type": "array",
      "allOf": [
        {
          "contains": {
            "required": [
              "value"
            ],
            "type": "object",
            "properties": {
              "value": {
                "pattern": "456"
              }
            }
          }
        },
        {
          "contains": {
            "required": [
              "value"
            ],
            "type": "object",
            "properties": {
              "value": {
                "pattern": "123"
              }
            }
          }
        }
      ],
      "items": {
        "type": "object",
        "required": [
          "value"
        ],
        "properties": {
          "value": {
            "enum": [
              "123",
              "456",
              "789"
            ],
            "type": "string"
          }
        }
      }
    }
  }
}

Data

{
  "data": [
    {
      "value": "123"
    },
    {
      "value": "456"
    }
  ]
}

Environment

- OS: any
- Node: any
- npm: any

Anything else?

• The problem is caused by jsonschema-merge-allof that is merging allOf values into the schema:

      "contains": {
        "required": [
          "value"
        ],
        "type": "object",
        "properties": {
          "value": {
            "allOf": [
              {
                "pattern": "123"
              },
              {
                "pattern": "456"
              }
            ]
          }
        }
      }

• This example was workable before this PR was merged. But I guess this PR just unmasked the issue.

[AlimovSV]

I tried to upgrade jsonschema-merge-allof to the latest version, but the result is similar, the retrieved schema contains:

      "contains": {
        "required": [
          "type"
        ],
        "type": "object",
        "properties": {
          "type": {
            "pattern": "(?=45e83143-f0f2-401b-b530-5965157d8e57)(?=52ea35ac-d8a0-4d6e-99b3-ee9a677c5579)"
          }
        }
      },

which is completely wrong. The logic is "data should contain {type:'123'} AND {type:'456'} items", not "data should contain item where type equal to 123 and 456"

[AlimovSV]

Looks like we have some regression from 4.2 to 5.xx for this case. Schema is valid, data matches to the schema, but RJSF@5 says that every item is wrong. I remember @nickgros fixed this issue for 4.2 and this works on the old project. But after upgrading to 5.x i faced with this issue again.

[nickgros]

@AlimovSV Thanks for the reproduction link, I'll reopen this

[AlimovSV]

Any updates?

[heath-freenome]

@AlimovSV We are looking for help in fixing this. Is this something you feel comfortable doing?

[AlimovSV]

@heath-freenome Thank you! At the moment I have to use v4.2 and freeze any upgrades.

[AlimovSV]

Any updates?

[heath-freenome]

@AlimovSV only that we could use help fixing this. Do you feel comfortable with doing that?

[AlimovSV]

@heath-freenome Unfortunately, I have no idea how to fix this :(

[AlimovSV]

Please release a new version with a fix for this issue (PR already merged).

[heath-freenome]

@AlimovSV Whoops, sorry. Just released