AnyOf/OneOf Merge Top Level Schema

[cwendtxealth]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.11.x

Current Behavior

In 5.11 there is a fix merging top level schema of oneOf/anyOf into the selected option field. This adds duplicated field on the UI; is this expected behavior? Before the fix it still had the top level field correctly and then showed the selected anyOf/oneOf fields.

Here is playground of the schema that is used in the unit test. Here is what is looks like

Before fix:

Expected Behavior

Only show the field once

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

No response

[heath-freenome]

@cwendtxealth I believe that this is actually a duplicate of #3787, at least in its solution:

This requires implementing a new feature similar to ui:fieldReplacesAnyOrOneOf except that it would be ui:anyOrOneOfReplacesField. In the SchemaField we render both the field and the anyOf/oneOf. With this flag turned on then I would imagine that the field being rendered on line 288 is skipped since the anyOf/oneOf will do it. This would required some verification of it working properly, including some decent unit tests. We could use some help for this.

Also, since you have been doing some great contributing, I would love to have you join our weekly meeting if you can

[cwendtxealth]

@heath-freenome I will play around with that solution and see what I can come up with!

Sure, I will see if I can make next weeks meeting!

[cwendtxealth]

@heath-freenome just from some quick initial tests when anyOf/oneOf schema field is present not rendering the top field works. However in my opinion I think it makes more sense to keep the top common field and then have it removed from the anyOf/oneOf options schema. Just from a UI prospective that field will be the same across all anyOf/oneOf options so having at the top outside I think is a nice visual of the schema.

I wanted to get your thoughts on possibly that type of solution. Im not sure exactly the best way of solving that. Two solutions come to mind

1. If the ui flag is set remove the top level properties before passing the anyOf/oneOf schema to the components
2. if the ui flag is set, in the MultiSchemaField hide the top level property widget in the anyOf/oneOf component

[heath-freenome]

Can you show me screenshots of what you have working now?

[cwendtxealth]

Sure, I am using the example from this issue as it has a little more complexity to show.

So here is the view without any changes (current). The important field is Select Application Type as that controls all of the if then statements. And you can see the duplication of that field and Untitled Design

Here is the view when not rendering the top level field and only showing anyOf/oneOf component. This solves the duplicate fields but I don't like this option as much because of two things. One you don't see the top level title anymore Upload Design File and now its hard to really tell which field is the driving factor for changing the if/then schema. In the one above because its at the top if gives you a better visual of the hierarchy.

Here is one of the solutions I suggested, where I am removing the top level properties in the schema before passing the anyOf/oneOf schema. This to me is the best solution for visually showing the schema as it keeps the top level fields and title while not repeating them in the oneOf/anyOf options. The only thing I don't know is if there are any side effects from not passing the full schema with top level properties of the anyOf/oneOf schema.