Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneOf no longer has error helper text for invalid field #3908

Closed
4 tasks done
bishopj15 opened this issue Oct 16, 2023 · 3 comments · Fixed by #3932
Closed
4 tasks done

oneOf no longer has error helper text for invalid field #3908

bishopj15 opened this issue Oct 16, 2023 · 3 comments · Fixed by #3932
Labels
any-one-all-of Related to fixing anyOf, oneOf or allOf bug help wanted validation

Comments

@bishopj15
Copy link

Prerequisites

What theme are you using?

material-ui

Version

5.13.1

Current Behavior

oneOf field does not include the "This field is required" helper text underneath the field

Expected Behavior

oneOf field has helper text underneath the field

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Anything else?

Playground link

@bishopj15 bishopj15 added bug needs triage Initial label given, to be assigned correct labels and assigned labels Oct 16, 2023
@nickgros
Copy link
Contributor

This is possibly caused by the change in #3795

It seems like there are some cases where we DO want to show the error message for oneOf/anyOf, like the SelectWidget case in the playground example.

@nickgros
Copy link
Contributor

@cwendtxealth do you have any time to take a look at this, since you made the original change?

@nickgros nickgros added help wanted any-one-all-of Related to fixing anyOf, oneOf or allOf validation and removed needs triage Initial label given, to be assigned correct labels and assigned labels Oct 20, 2023
@cwendtxealth
Copy link
Contributor

@cwendtxealth do you have any time to take a look at this, since you made the original change?

Yeah, I should have some time beginning of next week to take a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
any-one-all-of Related to fixing anyOf, oneOf or allOf bug help wanted validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants