fix: Fixes 1295 Duplicate Error Messages for Anyof/Oneof #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwendtxealth Can you post before/after Screenshots of the differences caused by the change? |
heath-freenome
changed the title
|
Before Fix |
…xealth/react-jsonschema-form into fixes-1295-duplicate-anyof-errors
cwendtxealth
commented
Jul 28, 2023
| Simulate.submit(node); | ||
|
|
||
| const matches = node.querySelectorAll('form .form-group .form-group .text-danger'); | ||
| expect(matches).to.have.length.of(1); |
There was a problem hiding this comment.
before fix matches would have length 2
heath-freenome
approved these changes
Aug 1, 2023
|
@cwendtxealth @heath-freenome This fix has caused an issue of Select components in antd, chakra-ui, and semantic theme packages that will not be validated. |
|
@dashdots can you create a new issue? |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1295, For anyOf/oneOf error messages were being shown at the top level anyOf/oneOf schema and the child schema that was resolved from the anyOf/oneOf logic. This PR updates SchemaField to only show error message at the child schema.
Checklist
npm run test:updateto update snapshots, if needed.