Issue when resetting certain numbers with a default value

[ayush-shta]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.x

Current Behavior

Numbers not resetting when the number entered in that field ends with the default value provided for that field in the schema

Expected Behavior

Values should reset as expected and should not depend upon what the default value is

Steps To Reproduce

I tried to replicate this issue in the playground. Link

1. Lets say I have a schema including one of the property to be like the one below. Here the default value of this field is 1.

  "number": {
      "title": "Number",
      "type": "number",
      "default": 1
    },

2. Now I type in the value for this filed as any number ending with the default value (for example, 11, 231, 0.1, 1.1, 2.1, 0.0001)
3. After that, lets click the button to reset the form
4. The value for that field does not reset
5. However if we type in any other number that does not end with the default value it will reset as expected

Environment

- OS:
- Node:
- npm:

Anything else?

No response

[nickgros]

Looks like a bug in the regular expression in NumberField:

react-jsonschema-form/packages/core/src/components/fields/NumberField.tsx

Line 74 in ec932db

const re = new RegExp(`${value}`.replace('.', '\\.') + '\\.?0*$');

The update is reverted because the new value matches the regular expression, when it should not match.

[nickgros]

Proposed fix here: #4220

[heath-freenome]

Fixed by #4420