Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation example for dynamically hiding widgets #1272

Closed

Conversation

jglev
Copy link

@jglev jglev commented Apr 30, 2019

First, thank you very much for your work on this project! I'm grateful for the work that's gone into the project to date.

Reasons for making this change

This PR updates the "Hidden Widget" documentation to include an example for dynamically hiding / filtering aspects of large forms. This new documentation would answer #598. The change I've proposed does not illustrate using a search box and the component's React state, but could be expanded to.

Is this a change that you think would be useful for others in the community to have available as an example?

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member

Thanks for the PR -- perhaps it would be more appropriate to add this as a codesandbox example instead of being its own section in the docs?

@jglev
Copy link
Author

jglev commented May 28, 2019

Sure, I can re-jig it to follow that approach!

@jglev
Copy link
Author

jglev commented May 28, 2019

@epicfaace, is b6febf7 in line with what you had in mind?

(prettier also automatically removed a few errant spaces in that commit; I can revert those if you prefer.)

@jglev jglev force-pushed the add-dynamic-hidden-widgets-documentation branch from 2aba7a6 to b6febf7 Compare May 29, 2019 12:56
@jglev
Copy link
Author

jglev commented May 29, 2019

Explaining my force-push just now: I rebased onto current master, so that my commits are on top of all of the latest changes.

@stale
Copy link

stale bot commented Apr 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.

@stale stale bot added the wontfix label Apr 15, 2022
@stale stale bot closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants