Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react is/1209 valid element type #2196

Closed

Conversation

wegry
Copy link
Contributor

@wegry wegry commented Jan 16, 2021

Reasons for making this change

This adds a test around my project's desire to break a moment (and moment-tz) dependency out of our main rjsf chunk by using React's Suspense.

This is an update to @jonathanhawleypeters's existent PR in #1737.

If this is related to existing tickets, include links to them as well.

I believe there are a few, but among others:

#1209
#2039

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@wegry wegry force-pushed the update-react-is/1209-valid-element-type branch 3 times, most recently from dd04ab9 to 7d07a8f Compare January 16, 2021 21:57
@wegry wegry force-pushed the update-react-is/1209-valid-element-type branch from 753c97a to 9fff0dc Compare April 17, 2021 22:42
@wegry wegry closed this Dec 8, 2021
@epicfaace
Copy link
Member

epicfaace commented Dec 8, 2021 via email

@wegry
Copy link
Contributor Author

wegry commented Dec 8, 2021

@epicfaace #2478 (comment)

@epicfaace
Copy link
Member

epicfaace commented Dec 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants