"examples" implementation for material-ui #2369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epicfaace is there any chance I can get a review here 🙏? |
epicfaace
reviewed
May 13, 2021
inrumi
force-pushed
the
inrumi/examples-4-materialui
branch
from
311cc5b
to
7a66b5e
Compare
inrumi
force-pushed
the
inrumi/examples-4-materialui
branch
from
7a66b5e
to
a5b04f4
Compare
Done! :D |
|
@epicfaace hi again! so I added the tests, everything is ok for this PR to be reviewed/merged? |
epicfaace
requested changes
Aug 13, 2021
| onBlur={_onBlur} | ||
| onFocus={_onFocus} | ||
| inputProps={{ | ||
| list: `examples_${id}`, |
There was a problem hiding this comment.
We shouldn't include this prop if schema.examples doesn't exist.
|
Please, we need this implementation... What needs to be done? |
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 29, 2022
- Updated the `BaseInputTemplate` in both `@rjsf/material-ui` and `@rjsf/mui` to add the examples implementation from rjsf-team#2369 - Added the `schema.examples` tests in the `Form.test.tsx`
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 29, 2022
- Updated the `BaseInputTemplate` in both `@rjsf/material-ui` and `@rjsf/mui` to add the examples implementation from rjsf-team#2369 - Added the `schema.examples` tests in the `Form.test.tsx`
8 tasks
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 29, 2022
- Updated the `BaseInputTemplate` in both `@rjsf/material-ui` and `@rjsf/mui` to add the examples implementation from rjsf-team#2369 - Added the `schema.examples` tests in the `Form.test.tsx`
heath-freenome
added a commit
that referenced
this pull request
Aug 29, 2022
* Reimplement #2369 in both material ui themes - Updated the `BaseInputTemplate` in both `@rjsf/material-ui` and `@rjsf/mui` to add the examples implementation from #2369 - Added the `schema.examples` tests in the `Form.test.tsx` * - Updated `CHANGELOG.md` for this fix as well as the fix for the previous commit - Commit the `semantic-ui` lock file since it was updated on my install * - Fixed issue with the wrong placement of the list - Updated tests accordingly - Also added `source-map-loader` to `playground` dev dependencies to fix playground * - Added antd, fluent-ui and semantic-ui as well
|
Fixed in v5 beta via refactor of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Related to the issue I raised heh 👉👈 #2368
This wasn't really complicated, most of the heavy lifting was in the bootstrap implementation.
If test are required I can work on them this weekend.
Checklist
Deploy preview
Once CI finishes, you should be able to view a deploy preview of the playground from this PR at this link: https://deploy-preview-[PR_NUMBER]--rjsf.netlify.app/