feat(bootstrap-4): support additionalProperties #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-form into feature/bootstrap-4-additional-properties
|
Curious how and why I’m including in this thread. I think I had 16-17
emails this AM for IT/dev-related concerns I didn’t submit a ticket for. I
don’t have a Github account and therefore can’t unsubscribe. Can you assist?
On Fri, Jun 18, 2021 at 9:29 AM Nick Grosenbacher ***@***.***> wrote:
Reasons for making this change
Hey, so I saw #2229
<#2229> hasn't
been touched in a few months and it seemed like it wouldn't take much to
get it over the finish line. I noticed that some of the work done in that
PR was made irrelevant by #2405
<#2405>, so I've
tried to remove the redundant code so it plays nicely.
This would partially fix #1927
<#1927>
Checklist
- *I'm updating documentation*
- I've checked the rendering
<https://react-jsonschema-form.readthedocs.io/en/latest/#contributing>
of the Markdown text I've added
- *I'm adding or updating code*
- I've added and/or updated tests
- I've updated docs <https://react-jsonschema-form.readthedocs.io/>
if needed
- *I'm adding a new feature*
- I've updated the playground with an example use of the feature
------------------------------
You can view, comment on, or merge this pull request online at:
#2429
Commit Summary
- feat(bootstrap-4): support additionalProperties & hide hidden fields
- Revert 'block', add tests for additionalProperties
- Merge branch 'master' of
https://github.com/rjsf-team/react-jsonschema-form into
feature/bootstrap-4-additional-properties
- Remove hidden field feature in favor of feature added in #2405
File Changes
- *M* packages/bootstrap-4/src/AddButton/AddButton.tsx
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-9a91305a1fc4f55fc8d8a0f4e00b9fdeacbf22d038751da190e366e092f33d41>
(2)
- *M* packages/bootstrap-4/src/FieldTemplate/FieldTemplate.tsx
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-bdf4af4b1ceeea97186581c5bdfbf464f071ec66627d40c67e7bbeb0a3ddffe0>
(77)
- *A* packages/bootstrap-4/src/FieldTemplate/WrapIfAdditional.tsx
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-d05502bd3376d7073db6294a8acd2a4655e076c3b8425e122ebe625c14add1db>
(80)
- *M*
packages/bootstrap-4/src/ObjectFieldTemplate/ObjectFieldTemplate.tsx
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-756fd02e2b2f85210a5456ff5ba2fdbde64bd14f948764d1294433df02287c60>
(26)
- *A* packages/bootstrap-4/test/AdditionalProperties.test.tsx
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-dd111265ae0017b8e19791019b50d220d9c05136e49d0c19325cbba3a789f942>
(17)
- *M* packages/bootstrap-4/test/__snapshots__/AddButton.test.tsx.snap
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-6a75a5cbd5b043ec3e05629fffaf7b7ffe02f176a63e52c9ccd8812c57c349d3>
(3)
- *A*
packages/bootstrap-4/test/__snapshots__/AdditionalProperties.test.tsx.snap
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-bbe073a7a9d31f2da7cd9ea528878d0a27607a08cbf718bbc41120c379be4800>
(174)
- *M* packages/bootstrap-4/test/__snapshots__/Array.test.tsx.snap
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-cb2d2c16e9a1c274ec4d9caa2ee0de1c8da3624c3f8e41671e759fc8298fa1aa>
(3)
- *M*
packages/bootstrap-4/test/__snapshots__/ArrayFieldTemplate.test.tsx.snap
<https://github.com/rjsf-team/react-jsonschema-form/pull/2429/files#diff-5c4a45abb7126833775273790a6ed752d0435fce04cb711fc3807832b6e8bdfb>
(3)
Patch Links:
- https://github.com/rjsf-team/react-jsonschema-form/pull/2429.patch
- https://github.com/rjsf-team/react-jsonschema-form/pull/2429.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2429>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOEHGIODUHL6YOC6GHALYDTTNX7ZANCNFSM4657D4PA>
.
--
[image: flipos] <http://flipos.com/>
Daniel HatmakerUnderwritingFlipOS by Stoa
714.418.3196
***@***.***
*flipos.com* <https://flipos.com/>
7525 E. 2nd St., #100, Scottsdale, AZ 85251
|
7 tasks
|
@danielstoa looks like you do have a github account at https://github.com/danielstoa -- you can configure email notifications at https://docs.github.com/en/github/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications |
|
The account you mention for Daniel Stoa is not me. The user uploaded a
photograph and it's not me. I never received any notifications until this
morning and I assure you I've never opened a GitHub account. Can you assist
with getting this issue resolved?
…On Fri, Jun 18, 2021 at 9:36 AM Ashwin Ramaswami ***@***.***> wrote:
@danielstoa <https://github.com/danielstoa> looks like you do have a
github account at https://github.com/danielstoa -- you can configure
email notifications at
https://docs.github.com/en/github/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2429 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOEHGO6TUZKCRSOPERU7S3TTNYXHANCNFSM4657D4PA>
.
--
[image: flipos] <http://flipos.com/>
Daniel HatmakerUnderwritingFlipOS by Stoa
714.418.3196
***@***.***
*flipos.com* <https://flipos.com/>
7525 E. 2nd St., #100, Scottsdale, AZ 85251
|
|
I can't, but you can contact github support at https://support.github.com/contact and they can get this resolved for you. |
|
Hey @epicfaace, any chance of getting this merged? |
|
@epicfaace todo review this |
|
Hey @epicfaace, any chance of getting this merged? |
|
Can you add it to the meeting agenda so we can schedule a synchronous review #2677 |
|
Added it to the meeting minutes, would be great if this could be merged. |
epicfaace
reviewed
Feb 25, 2022
packages/bootstrap-4/src/ObjectFieldTemplate/ObjectFieldTemplate.tsx
Outdated
Show resolved
Hide resolved
packages/bootstrap-4/test/__snapshots__/ArrayFieldTemplate.test.tsx.snap
Outdated
Show resolved
Hide resolved
epicfaace
reviewed
Feb 25, 2022
packages/bootstrap-4/test/__snapshots__/AddButton.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/bootstrap-4/test/__snapshots__/AdditionalProperties.test.tsx.snap
Outdated
Show resolved
Hide resolved
epicfaace
approved these changes
Feb 25, 2022
| icon="remove" | ||
| tabIndex={-1} | ||
| disabled={disabled || readonly} | ||
| onClick={onDropPropertyClick(label)} |
There was a problem hiding this comment.
Added variant="danger"
| /> | ||
| </Form.Group> | ||
| </Col> | ||
| <Col xs={6}> |
There was a problem hiding this comment.
Suggested change
| <Col xs={6}> | |
| <Col xs={5}> |
| <Col xs={6}> | ||
| {children} | ||
| </Col> | ||
| <Col xs={1} className="py-4"> |
There was a problem hiding this comment.
Suggested change
| <Col xs={1} className="py-4"> | |
| <Col xs={2} className="py-4"> |
| </Col> | ||
| <Col xs={1} className="py-4"> | ||
| <IconButton | ||
| icon="remove" |
There was a problem hiding this comment.
potentially see if we could make it wider / if bootstrap has an easy class name to do so, then let's do it.
There was a problem hiding this comment.
Added prop block={true}
There was a problem hiding this comment.
Why not just block? True is inferred then.
…a-form into feature/bootstrap-4-additional-properties
…m:nickgros/react-jsonschema-form into feature/bootstrap-4-additional-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Hey, so I saw #2229 hasn't been touched in a few months and it seemed like it wouldn't take much to get it over the finish line. I noticed that some of the work done in that PR was made irrelevant by #2405, so I've tried to remove the redundant code so it plays nicely.
This would partially fix #1927
Checklist