Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using active voice for section on allOf/anyOf dereferencing #2433

Merged

Conversation

wegry
Copy link
Contributor

@wegry wegry commented Jun 22, 2021

https://github.com/rjsf-team/react-jsonschema-form/issues/2297\#issuecomment-866263746

Reasons for making this change

https://github.com/rjsf-team/react-jsonschema-form/issues/2297\#issuecomment-866263746"

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@epicfaace epicfaace merged commit 579af3f into rjsf-team:master Jun 23, 2021
@wegry wegry deleted the attempt-to-smoothe-two-voices-together branch June 23, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants