Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable source maps in playground, for development #2568

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Enable source maps in playground, for development #2568

merged 2 commits into from
Sep 28, 2021

Conversation

RAM92
Copy link
Contributor

@RAM92 RAM92 commented Sep 28, 2021

Reasons for making this change

These changes are to enable debugging of source files in the browser while running the Playground package.

epicfaace
epicfaace reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@epicfaace epicfaace left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know if this will significantly slow down compilation of development code, or is it still reasonably fast enough?

@RAM92
Copy link
Contributor Author

RAM92 commented Sep 28, 2021

I have not used it extensively, but in initial tests it seemed fine.

epicfaace
epicfaace approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks.

@epicfaace epicfaace merged commit 009a646 into rjsf-team:master Sep 28, 2021
@RAM92 RAM92 deleted the feature/setup-source-maps branch September 28, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RAM92 @epicfaace