Support customization / props of submit button using ui:submitButtonOptions #2640

jacqueswho · 2021-12-29T10:20:16Z

Reasons for making this change

Currently there is no options to hide the submit button or change the text of the button. ui:submitButtonProps will allow you to change the text, if it is required for readonly forms and disable it. Fixes #1602

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

Merging latest changes

Merge latest changes

jacqueswho · 2021-12-29T10:34:04Z

@epicfaace I have made the feature regarding submitButtonProps. Not sure how I can make the other themes pass without the functionality not existing as of yet. So how do I update the tests of the other themes if getSubmitButtonProps does not exist yet

docs/api-reference/uiSchema.md

jacqueswho · 2021-12-29T15:55:37Z

@epicfaace maybe I should remove all the theme related changes and put that in a separate request, when this is available?

jacqueswho · 2022-01-03T17:52:11Z

@epicfaace please let me know what I need to change. If you want me to exclude the other theme changes as separate pull request after this is merged in I can do that

jacqueswho · 2022-01-13T12:39:27Z

@epicfaace can this be merged in then?

docs/api-reference/uiSchema.md

epicfaace

"ui:submitOptions": {"props": {}, "allowed": true}}
Remove "allowed" to "removed" ("removed" is set to false by default)

CHANGELOG.md

packages/antd/package.json

docs/api-reference/uiSchema.md

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

jacqueswho · 2022-01-24T10:54:10Z

@epicfaace all good

jacqueswho · 2022-03-05T06:38:03Z

lgtm, Please update snapshots and then we will merge.

@epicfaace So this is the part I dont understand. I have, below are the commands I have run.
git pull origin master
git pull upstream master
npm run test:update

…ueswho/react-jsonschema-form into jacqueswho-feature/submit_button_props

epicfaace · 2022-03-15T14:51:14Z

@jacqueswho I tried running tests and got some test failures as well (in addition to snapshot failures):

…nto feature/submit_button_props

…eact-jsonschema-form into feature/submit_button_props

…nto feature/submit_button_props

epicfaace · 2022-04-11T13:55:16Z

Did github codespaces do the trick?

…nto feature/submit_button_props

jacqueswho · 2022-04-12T19:07:10Z

Did github codespaces do the trick?

I dont understand it. I updated and pushed but its still failing.

…a-form

dwjohnston · 2022-04-26T06:46:50Z

CC @jacqueswho I'm wondering if this PR had an error, or the package has not published properly - see #2831

According to NPM - last publish was a month ago - so possibly the latter.

heath-freenome · 2022-04-27T04:31:26Z

packages/material-ui/src/SubmitButton/SubmitButton.tsx

@@ -0,0 +1,20 @@
+import React from 'react';
+import Box from "@material-ui/core/Box";


@epicfaace @jacqueswho The pattern for @material-ui is different, we don't import directly from @material-ui/core anymore.

heath-freenome · 2022-04-27T04:31:42Z

packages/material-ui/src/SubmitButton/SubmitButton.tsx

+import Box from "@material-ui/core/Box";
+import { WidgetProps, utils } from '@rjsf/core';
+
+import Button from '@material-ui/core/Button';


Ditto on import, instead, this should be:

import { useMuiComponent } from '../MuiComponentContext';

heath-freenome · 2022-04-27T04:33:36Z

packages/material-ui/src/SubmitButton/SubmitButton.tsx

+
+const { getSubmitButtonOptions } = utils;
+const SubmitButton: React.FC<WidgetProps> = props => {
+  const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(props.uiSchema);


Get the Box and Button from the context.

const { Box, Button } = useMuiComponent();

heath-freenome · 2022-04-27T04:36:30Z

CHANGELOG.md

+- Feature for ui:submitButtonOptions on the submit button for forms (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)

+## Dev / docs / playground
+- Enable ui options in playground, to demonstrate submit button options (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)
+
+## @rjsf/bootstrap-4
+- SubmitButton widget to use new ui:submitButtonOptions on the submit button for forms (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)
+
+## @rjsf/semantic-ui
+- SubmitButton widget to use new ui:submitButtonOptions on the submit button for forms (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)
+
+## @rjsf/antd
+- SubmitButton widget to use new ui:submitButtonOptions on the submit button for forms (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)
+
+## @rjsf/fluent-ui
+- SubmitButton widget to use new ui:submitButtonOptions on the submit button for forms (https://github.com/rjsf-team/react-jsonschema-form/pull/2640)


@jacqueswho This should be moved up under a new 4.2.0 section (4.1.1 was already released) rather than being under v3.2.1 and include ## @material-ui as well, since we actually haven't published this feature yet.

jacqueswho added 6 commits April 9, 2020 09:05

Merge pull request #2 from rjsf-team/master

eef9605

Merging latest changes

Merge pull request #4 from rjsf-team/master

04b3d07

Merge latest changes

Merge branch 'rjsf-team:master' into master

9e2dff9

feat: submit button props

28e86ba

feat: ui options playground options

0f4c77c

feat: other themes to implement widget

807a377

epicfaace reviewed Dec 29, 2021

View reviewed changes

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

feat: remove hidden option

43a175f

epicfaace reviewed Jan 14, 2022

View reviewed changes

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

chore: required to allowed

7656dd3

epicfaace reviewed Jan 17, 2022

View reviewed changes

chore: requested changes

7b4673a

jacqueswho requested a review from epicfaace January 17, 2022 15:36

doc: change prop

1c2800d

epicfaace reviewed Jan 17, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

epicfaace reviewed Jan 17, 2022

View reviewed changes

packages/antd/package.json Outdated Show resolved Hide resolved

chore: version bump changes

4c5960c

jacqueswho requested a review from epicfaace January 18, 2022 04:36

Update CHANGELOG.md

ff636fe

epicfaace requested changes Jan 18, 2022

View reviewed changes

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

docs/api-reference/uiSchema.md Outdated Show resolved Hide resolved

jacqueswho and others added 4 commits January 18, 2022 18:50

Update docs/api-reference/uiSchema.md

492a2bc

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

Update docs/api-reference/uiSchema.md

20cf440

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

Update docs/api-reference/uiSchema.md

1a484d5

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

dox: updated

16bc002

jacqueswho requested a review from epicfaace January 18, 2022 17:10

jacqueswho added 2 commits March 5, 2022 08:14

test: snapshots updated

e6fd8cb

chore: norender changes

cb89a03

epicfaace added 2 commits March 15, 2022 14:47

Merge branch 'feature/submit_button_props' of https://github.com/jacq…

0088b0d

…ueswho/react-jsonschema-form into jacqueswho-feature/submit_button_props

revert

62fc572

epicfaace and others added 8 commits March 15, 2022 15:03

update snapshots

2f677cd

fix: include correct code again for submit button props

769a035

chore: update snapshots

386a029

Merge branch 'master' into feature/submit_button_props

6b176aa

Merge branch 'master' of github.com:rjsf-team/react-jsonschema-form i…

8ac01ee

…nto feature/submit_button_props

Merge branch 'master' into feature/submit_button_props

9b440d3

Merge branch 'feature/submit_button_props' of github.com:jacqueswho/r…

43e79a6

…eact-jsonschema-form into feature/submit_button_props

Merge branch 'master' of github.com:rjsf-team/react-jsonschema-form i…

8ee49f5

…nto feature/submit_button_props

jacqueswho added 4 commits April 12, 2022 17:19

Merge branch 'master' of github.com:rjsf-team/react-jsonschema-form i…

23dea6f

…nto feature/submit_button_props

chore: update snapshots

540f456

chore: snapshots updated

1fe1e4c

chore: update snapshots semantic-ui

e1ebb05

jacqueswho added 4 commits April 13, 2022 08:55

Merge branch 'master' of https://github.com/rjsf-team/react-jsonschem…

fe2d6ae

…a-form

chore: get latest version master

8462132

Merge branch 'master' into feature/submit_button_props

4b8f901

chore: snapshots updated

0b436f1

jacqueswho merged commit 57f00cb into rjsf-team:master Apr 13, 2022

jacqueswho deleted the feature/submit_button_props branch April 13, 2022 15:37

dwjohnston mentioned this pull request Apr 26, 2022

ui:submitButtonOptions don't work. #2831

Closed

3 tasks

heath-freenome reviewed Apr 27, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support customization / props of submit button using ui:submitButtonOptions #2640

Support customization / props of submit button using ui:submitButtonOptions #2640

jacqueswho commented Dec 29, 2021 •

edited by epicfaace

Loading

jacqueswho commented Dec 29, 2021

jacqueswho commented Dec 29, 2021

jacqueswho commented Jan 3, 2022

jacqueswho commented Jan 13, 2022

epicfaace left a comment

jacqueswho commented Jan 24, 2022

jacqueswho commented Mar 5, 2022 •

edited

Loading

epicfaace commented Mar 15, 2022

epicfaace commented Apr 11, 2022

jacqueswho commented Apr 12, 2022

dwjohnston commented Apr 26, 2022 •

edited

Loading

heath-freenome Apr 27, 2022 •

edited

Loading

heath-freenome Apr 27, 2022

heath-freenome Apr 27, 2022 •

edited

Loading

heath-freenome Apr 27, 2022 •

edited

Loading

		@@ -0,0 +1,20 @@
		import React from 'react';
		import Box from "@material-ui/core/Box";

Support customization / props of submit button using ui:submitButtonOptions #2640

Support customization / props of submit button using ui:submitButtonOptions #2640

Conversation

jacqueswho commented Dec 29, 2021 • edited by epicfaace Loading

Reasons for making this change

Checklist

jacqueswho commented Dec 29, 2021

jacqueswho commented Dec 29, 2021

jacqueswho commented Jan 3, 2022

jacqueswho commented Jan 13, 2022

epicfaace left a comment

Choose a reason for hiding this comment

jacqueswho commented Jan 24, 2022

jacqueswho commented Mar 5, 2022 • edited Loading

epicfaace commented Mar 15, 2022

epicfaace commented Apr 11, 2022

jacqueswho commented Apr 12, 2022

dwjohnston commented Apr 26, 2022 • edited Loading

heath-freenome Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

heath-freenome Apr 27, 2022

Choose a reason for hiding this comment

heath-freenome Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

heath-freenome Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

jacqueswho commented Dec 29, 2021 •

edited by epicfaace

Loading

jacqueswho commented Mar 5, 2022 •

edited

Loading

dwjohnston commented Apr 26, 2022 •

edited

Loading

heath-freenome Apr 27, 2022 •

edited

Loading

heath-freenome Apr 27, 2022 •

edited

Loading

heath-freenome Apr 27, 2022 •

edited

Loading