fix(@rjsf-antd): Submit button type bug (#2867) #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarpere
changed the title
sarpere
changed the title
sarpere
changed the title
|
@sarpere Please revert all of the |
…ct-jsonschema-form into rjsf-antd-submit-bug
…ct-jsonschema-form into rjsf-antd-submit-bug
…ct-jsonschema-form into rjsf-antd-submit-bug
This reverts commit afdd34c.
heath-freenome
approved these changes
May 23, 2022
| @@ -5,7 +5,7 @@ const { getSubmitButtonOptions } = utils; | |||
| export default ({ uiSchema }) => { | |||
| const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(uiSchema); | |||
| if (norender) {return null;} | |||
| return (<Button type="submit" {...submitButtonProps}> | |||
| return (<Button htmlType={"submit"} {...submitButtonProps}> | |||
There was a problem hiding this comment.
Consider simplifying this to htmlType="submit"
There was a problem hiding this comment.
Also I have done this.
|
I have updated the repo. |
| @@ -5,7 +5,7 @@ const { getSubmitButtonOptions } = utils; | |||
| export default ({ uiSchema }) => { | |||
| const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(uiSchema); | |||
| if (norender) {return null;} | |||
| return (<Button type="submit" {...submitButtonProps}> | |||
| return (<Button htmlType="submit" {...submitButtonProps}> | |||
There was a problem hiding this comment.
Minor little thing... there seems to be an extra space between Button and htmlType that you are welcome to remove even though it was there before
There was a problem hiding this comment.
It look like you are going to have to update the test snapshots as a result of this change
There was a problem hiding this comment.
I have updated snapshots. You can try to trigger workflow. I'm not getting test run bug.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Ant design theme assigned with wrong props. This is causing the form to fail to submit.
I have updated submit button prop;
from type to HtmlType.
fixes #2867