fix: Add programmatic form validation support #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `Form` to add a new `validateForm()` function by refactoring that portion of the code out of the `onSubmit()` callback - Updated the playground to add a new `Prog. Validate` button to programmatically validate a form - Moved the `Share` button onto the next line and changed `Programmatically Submit` button to `Prog. Submit` - Added an alert when the form is submitted - Updated the `validation.md` documentation with this new capability - Updated the `CHANGELOG.md` file accordingly
heath-freenome
force-pushed
the
add-programmatic-validation
branch
from
406f82a
to
9e2ad99
Compare
heath-freenome
force-pushed
the
add-programmatic-validation
branch
from
9e2ad99
to
e8ad5e0
Compare
nickgros
approved these changes
Sep 19, 2022
jacqueswho
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #2755, #2552, #2381, #2343, #1006, #246
Formto add a newvalidateForm()function by refactoring that portion of the code out of theonSubmit()callbackProg. Validatebutton to programmatically validate a formSharebutton onto the next line and changedProgrammatically Submitbutton toProg. Submitvalidation.mddocumentation with this new capabilityCHANGELOG.mdfile accordinglyChecklist
npm run test:updateto update snapshots, if needed.