Add "list-inline-item" as a class name on LI elements in the AltDateWidget #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danfunk Can you add a test that verifies this change as well as updating the |
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Feb 4, 2023
Fixes: rjsf-team#3424 by preventing the inclusion of undefined properties at the root level - Updated `@rjsf/utils`, making `computeDefaults` helper in `getDefaultFormState()` to skip adding undefined values when `excludeObjectChildren` is set. - This basically supports adding an empty object - Updated the tests accordingly - Updated the `CHANGELOG.md` accordingly - Also added information the changelog for PR rjsf-team#3202
heath-freenome
approved these changes
Feb 4, 2023
8 tasks
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Feb 4, 2023
Fixes: rjsf-team#3424 by preventing the inclusion of undefined properties at the root level - Updated `@rjsf/utils`, making `computeDefaults()` helper in `getDefaultFormState()` to skip adding undefined values when `allowEmptyObject` is set. - Updated the `getDefaultFormState()` definition in the `ValidatorType` to add this new option - Updated the tests accordingly - Updated `@rjsf/core`, switching the `excludeObjectChildren` with `allowEmptyObject` in `Form` - Updated the documentation for `getDefaultFormState()` to add this new option - Updated the `CHANGELOG.md` accordingly - Also added information the changelog for PR rjsf-team#3202
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Feb 5, 2023
Fixes: rjsf-team#3424 by preventing the inclusion of undefined properties at the root level - Updated `@rjsf/utils`, making `computeDefaults()` helper in `getDefaultFormState()` to skip adding undefined values when `allowEmptyObject` is set. - Updated the `getDefaultFormState()` definition in the `ValidatorType` to add this new option - Updated the tests accordingly - Updated `@rjsf/core`, switching the `excludeObjectChildren` with `allowEmptyObject` in `Form` - Updated the documentation for `getDefaultFormState()` to add this new option - Updated the `CHANGELOG.md` accordingly - Also added information the changelog for PR rjsf-team#3202
heath-freenome
added a commit
that referenced
this pull request
Feb 5, 2023
* Fix: Prevent undefined properties at the root level Fixes: #3424 by preventing the inclusion of undefined properties at the root level - Updated `@rjsf/utils`, making `computeDefaults()` helper in `getDefaultFormState()` to skip adding undefined values when `allowEmptyObject` is set. - Updated the `getDefaultFormState()` definition in the `ValidatorType` to add this new option - Updated the tests accordingly - Updated `@rjsf/core`, switching the `excludeObjectChildren` with `allowEmptyObject` in `Form` - Updated the documentation for `getDefaultFormState()` to add this new option - Updated the `CHANGELOG.md` accordingly - Also added information the changelog for PR #3202 * - Responded to reviewer feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rap 4 docs: https://getbootstrap.com/docs/4.0/content/typography/#inline
Reasons for making this change
use list-inline-item for li items in the AltDateWidget, as per bootstrap 4 docs: https://getbootstrap.com/docs/4.0/content/typography/#inline
It is a minor change. I did run the tests to assure this does not break anything.
Checklist
npm run test:updateto update snapshots, if needed.Before:
After:
