fix: Reimplement #2548 to fix #2262 #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: rjsf-team#2262 - Updated `@rjsf/utils` to update the `toPathSchema()` method to pick the closest matching option for `oneOf`/`anyOf` choices to render a path schema for it - Updated test to maintain 100% coverage - Updated `@rjsf/core` to cache retrieved options in state for use in the rest of the component - Also improved enumOptions to output better labels for options without them when a title is available in either the `schema` or `uiSchema` - Added tests to validate both fixes - Updated the `CHANGELOG.md` accordingly
nickgros
changed the title
7 tasks
nickgros
approved these changes
Jan 25, 2023
- Accepted reviewer suggestions Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes: #2262 by reimplementing #2548
@rjsf/utilsto update thetoPathSchema()method to pick the closest matching option foroneOf/anyOfchoices to render a path schema for it@rjsf/coreto cache retrieved options in state for use in the rest of the componentschemaoruiSchemaCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.