Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix #3391 and #3393 #3408

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Conversation

heath-freenome
Copy link
Member

@heath-freenome heath-freenome commented Jan 27, 2023

Reasons for making this change

Fixes #3391 by adding the excludeObjectChildren third parameter to the main getDefaultFormState()
Fixes #3393 by properly deduplicating when schema.default exists in schema.examples

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Fixes rjsf-team#3391 by adding the `excludeObjectChildren` third parameter to the main `getDefaultFormState()`
@heath-freenome heath-freenome changed the title fix: Fix 3391 by restoring creation of empty root objects fix: Fix 3391 and 3393 Jan 27, 2023
@nickgros nickgros changed the title fix: Fix 3391 and 3393 fix: Fix #3391 and #3393 Jan 27, 2023
@heath-freenome heath-freenome merged commit 2e96fe2 into rjsf-team:main Jan 27, 2023
@heath-freenome heath-freenome deleted the fix-3391 branch January 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String with examples does not work with default theme Nested properties validation
2 participants